Add timeout handling for RG15 #22768
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arendst
reviewed
Jan 5, 2025
arendst
reviewed
Jan 5, 2025
arendst
reviewed
Jan 5, 2025
arendst
reviewed
Jan 6, 2025
| // if the parsing wasn't completely successful then skip the update | ||
| if( !isnan(Rg15.acc) && !isnan(Rg15.event) && !isnan(Rg15.total) && !isnan(Rg15.rate) ) { | ||
| ResponseAppend_P(PSTR(",\"" RG15_NAME "\":{")); | ||
| ResponseAppend_P(PSTR("\"%s\":%s,"), D_JSON_VALID, &aString); |
There was a problem hiding this comment.
How about
ResponseAppend_P(PSTR("\"%s\":%d,"), D_JSON_VALID, Rg15.isSensorAvailable);
and getting rid off BOOL_TO_STRING and supporting code.
arendst
reviewed
Jan 6, 2025
| ResponseAppend_P(PSTR("\"%s\":%2_f,"), D_JSON_ACTIVE, &Rg15.acc); | ||
| ResponseAppend_P(PSTR("\"%s\":%2_f,"), D_JSON_EVENT, &Rg15.event); | ||
| ResponseAppend_P(PSTR("\"%s\":%2_f,"), D_JSON_TOTAL, &Rg15.total); | ||
| ResponseAppend_P(PSTR("\"%s\":%2_f"), D_JSON_FLOWRATE, &Rg15.rate); | ||
| ResponseAppend_P(PSTR("}")); | ||
| } else { |
There was a problem hiding this comment.
Pls remove the else clause; Having Valid with the other values makes enough sense (and saves code space).
|
Thx. Based on your work I will update the driver with your suggested functionality. You don't have to respond to the questions I asked today. Hold on.... |
arendst
added a commit
that referenced
this pull request
Jan 6, 2025
|
(Some kind of) Merged in latest branch |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add timeout handling for RG15 (rain sensor).
Related issue (if applicable): fixes #
Rainsensor Optical Rain Gauge RG-15 #22612
Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass