Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring of mdunlink_ao #961

Open
wants to merge 1 commit into
base: adb-7.1.0
Choose a base branch
from
Open

Refactoring of mdunlink_ao #961

wants to merge 1 commit into from

Conversation

anterohamalainen
Copy link

  1. The relpath function was called two times.
  2. strncpy has been replaced with strcpy, because the input buffer is always of sufficient size.
  3. Place strcpy closer to palloc.
  4. Remove the segPathSuffixPosition redundant variable.
  5. Initialize all unlinkFiles fields in one statement. If someday a new field will be added to the unlinkFiles structure, then it will be initialized.

@anterohamalainen
Refactoring of mdunlink_ao
9bd3a7b 
1. The relpath function was called two times.
2. strncpy has been replaced with strcpy, because the input buffer is always of
sufficient size.
3. Place strcpy closer to palloc.
4. Remove the segPathSuffixPosition redundant variable.
5. Initialize all unlinkFiles fields in one statement. If someday a new field
will be added to the unlinkFiles structure, then it will be initialized.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@anterohamalainen