Fix BlockRepository setting relation of an object and improve amount … #2672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tofandel
commented
Oct 15, 2024
Tofandel
commented
Oct 15, 2024
|
|
||
| // Delete all the related items that were emptied | ||
| RelatedItem::query()->whereMorphedTo('subject', $model)->whereNotIn('browser_name', $browserNames)->delete(); | ||
| } else { | ||
| $model->clearAllRelated(); |
There was a problem hiding this comment.
This would previously delete and recreate all related items, which is very write intensive on the database for nothing because saveRelated already does an existence check and deletes the deleted ones
|
Thanks @Tofandel, can you make sure to test the 3 following things:
|
|
Hey @Tofandel, I didn't test this extensively yet but looks like you fixed it, I was able to reproduce the error here and when switching to your branch I don't have it anymore. Thank you! |
ifox
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2671
And improve saving performance by avoiding uneccessary queries