Fix repeaters are registered without a populated item #2605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tofandel
force-pushed
the
fix/repeater-populated
branch
2 times, most recently
from
07af4c9
to
1045330
Compare
Tofandel
force-pushed
the
fix/repeater-populated
branch
from
1045330
to
e3022a8
Compare
ifox
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repeaters are registered in the Controller constructor without any model (I'm guessing so that the repeaters are available to the TwillBlocks facade early on)
But this is problematic as then if you change available select options or fields based on the model, the repeater templates are not updated, this PR fixes this issue by registering the repeaters again when they have been populated
It also fixes a performance issue with
->form()being unnecessarily called twice everywhere in the controller (the form method already sharesformto laravel)