Improve related save #2599
Merged
Improve related save #2599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tofandel
commented
Jun 5, 2024
| $firstMatchKey = $itemsToProcess | ||
| ->where('related_id', $item['id']) | ||
| ->where('related_type', $item['endpointType']) | ||
| ->where('browser_name', $browserName) |
There was a problem hiding this comment.
This is already taken care of in line 71
Tofandel
force-pushed
the
fix/improve-related-save
branch
from
cf761f0
to
73ee668
Compare
Tofandel
force-pushed
the
fix/improve-related-save
branch
from
73ee668
to
0a455b1
Compare
ifox
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick PR to improve
saveRelatedto work with models, I wanted to use it and according to the phpdoc it accepts an array of Twill model, but this is not the case (it only accepts an array withidandendpointType)This PR allows the method to accept models as well and improves the performance by using only one
whereinstead of 3 which would iterate 3 times over the collectionI also added
$item->unsetRelation('related')in loadRelated, otherwise there is a circular reference in the model relation (model -> pivot -> related -> model ...) which causes an infinite loop when usingmodel->toArray()