parseInternalLinks corrections for double digit ids #2338
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue 1: While rendering a linked
browserModule
using$block->wysiwyg('field')
, the logic picks only single digit of the id. For eg.if this is the href of a link
#twillInternalLink::App\Models\Category#23
, the current logic will only pick2
asid
instead of23
Issue 2: the current logic only query for published records. It doesn't handle a scenario when a linked published record gets unpublished.
Issue 3: Regex
/(#twillInternalLink::(.*)#(\d+))/
breaks when there are multiple links in a block. It catches the first and the last "#"This PR handles both the scenarios by
fix 1. correcting the regex
fix 2. adding a 404 when the model is not found
fix 3. changed regex to pick the shortest matching string which makes the model search end as the first "#"