Remove duplicate database calls for AppSettings #2304
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Jigsaw5279
force-pushed
the
feature/limit-app-setting-queries
branch
2 times, most recently
from
5e9e97d
to
4ebf226
Compare
Jigsaw5279
force-pushed
the
feature/limit-app-setting-queries
branch
from
4ebf226
to
ddcc48e
Compare
|
Thanks for your contribution and sorry for the delay to review and merge. In the meantime, another contributor submitted a more robust solution building upon yours. It has been merged in #2369 and will be released in Twill 3.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using the AppSettings facade created a ton of duplicate calls to the database.
This PR introduces two small in-memory array caches to entirely remove those duplicate calls