Skip to content
This repository has been archived by the owner on Apr 10, 2021. It is now read-only.

244 #256

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

244 #256

wants to merge 5 commits into from

Conversation

chan18
Copy link
Contributor

@chan18 chan18 commented Apr 12, 2020

Pull request content

User management

  • Username,
  • Email
  • Roles

Notes for admin

Roles are not updating properly, Need some info on how to fix this.

@CLAassistant
Copy link

CLAassistant commented Apr 12, 2020

CLA assistant check
All committers have signed the CLA.

@chan18 chan18 requested a review from keggyy April 27, 2020 07:53
@@ -68,7 +67,7 @@
"deleteConfirmMsgTpl": "Are you sure you want to delete lambda {name}?",
"deleteErrorMsgTpl": "An error occurred while deleting lambda {name}.",
"deleteSuccessMsgTpl": "Lambda {name} was deleted.",
"emptyMsg": "There are no lambdas yet. Add some with the button below!",
"empt1yMsg": "There are no lambdas yet. Add some with the button below!",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo error?

return {
nameRules: [v => !!v || this.$t('core.users.detail.requiredNameMsg')],
emailRules: [v => !!v || this.$t('core.users.detail.requiredEmailMsg')],
emailRules: [v => !!v || this.$t('core.users.detail.requiredRoleslMsg')],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the rule for role has emailRules name?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants