Skip to content

add WiFiCaptive arduino library #6383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025
Merged

Conversation

ExMikuPro
Copy link
Contributor

No description provided.

Copy link
Contributor

github-actions bot commented Jun 4, 2025

A problem was found with your submission https://github.com/ExMikuPro/WiFiCaptive

ERROR: Library is missing a library.properties metadata file.

See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-metadata

@github-actions github-actions bot added the topic: submission Add library to the list label Jun 4, 2025
Copy link
Contributor

github-actions bot commented Jun 4, 2025

Thanks for your interest in contributing to the Arduino Library Manager index @ExMikuPro
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@ExMikuPro ExMikuPro closed this Jun 4, 2025
@ExMikuPro ExMikuPro reopened this Jun 4, 2025
@ExMikuPro ExMikuPro changed the title add WiFiCaptive arduino libary add WiFiCaptive arduino library Jun 4, 2025
@ExMikuPro
Copy link
Contributor Author

Please check it again @ArduinoBot.

Copy link
Contributor

github-actions bot commented Jun 4, 2025

Hello! I'm checking your submission again.

Copy link
Contributor

github-actions bot commented Jun 4, 2025

A problem was found with your submission https://github.com/ExMikuPro/WiFiCaptive

ERROR: Library is missing a library.properties metadata file.

See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-metadata

Copy link
Contributor

github-actions bot commented Jun 4, 2025

Thanks for your interest in contributing to the Arduino Library Manager index @ExMikuPro
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@per1234 per1234 self-assigned this Jun 4, 2025
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ExMikuPro . I see you have fixed the error reported by the bot. However, Library Manager works exclusively from Git tags, so the bot won't be able to see the fix you made until you create a new release or tag in the library repository.

If you look at the repository contents at the latest tag, you can see that the version the bot is checking still has the problem:

https://github.com/ExMikuPro/WiFiCaptive/tree/v0.1.0

(note that a library.properties file was not present at that tagged point in the revision history)

❗ Remember to update the version field in the library's library.properties file as needed before making a release/tag.

Once you have done that, simply mention @ArduinoBot in a comment here to trigger it to run the automated checks again. After those are passing, your library will be automatically added to Library Manager.

If you have any questions or concerns, please let me know.

Regards, Per

@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Jun 4, 2025
@ExMikuPro
Copy link
Contributor Author

@ArduinoBot please check again, I have created a new release with the required library.properties file.

Copy link
Contributor

github-actions bot commented Jun 4, 2025

Hello! I'm checking your submission again.

@github-actions github-actions bot removed the status: waiting for information More information must be provided before work can proceed label Jun 4, 2025
Copy link
Contributor

github-actions bot commented Jun 4, 2025

Arduino Lint has suggestions for possible improvements to https://github.com/ExMikuPro/WiFiCaptive:

Linting library in WiFiCaptive

Linter results for project: no errors or warnings

-------------------

Linting sketch in WiFiCaptive/examples/ESPWiFiCaptiveEasyDemo
WARNING: Sketch file/folder name mismatch. The primary sketch file name must match the folder:                          
         ESPWiFiCaptiveEasyDemo.ino                                                                                     
         See: https://arduino.github.io/arduino-cli/latest/sketch-specification/#primary-sketch-file                    
         (Rule SS001)                                                                                                   

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

Linter results for projects: 0 ERRORS, 1 WARNINGS

@github-actions github-actions bot merged commit 14efb1f into arduino:main Jun 4, 2025
14 checks passed
Copy link
Contributor

github-actions bot commented Jun 4, 2025

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/ExMikuPro/WiFiCaptive/

github-actions bot pushed a commit that referenced this pull request Jun 4, 2025
@ExMikuPro
Copy link
Contributor Author

@ArduinoBot please check again, I have fixed the sketch name warning and published v0.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants