Add function getYears, getMonths, getDays#184
Add function getYears, getMonths, getDays#184thaianhtaivn wants to merge 1 commit intoarduino-libraries:masterfrom thaianhtaivn:master
Conversation
|
|
per1234
added
type: enhancement
|
Hello @per1234 , |
|
Hi @thaianhtaivn. Thanks for your pull request. My role in this project is somewhat janitorial in nature. I don't make the decisions about which pull requests are merged or not. I commented to provide some supplemental information that might be of use to the reviewers. Regards, |
lukaszgieraltowski
left a comment
lukaszgieraltowski
left a comment
There was a problem hiding this comment.
Good job. I'd suggest to add getFormattedDateTime using new methods. Analogously to getFormattedTime.
| return (this->getEpochTime() % 60); | ||
| } | ||
| int NTPClient::getYears() const { | ||
| time_t rawtime = this->getEpochTime(); |
There was a problem hiding this comment.
Use two spaces for indentation instead of four.
| int getHours() const; | ||
| int getMinutes() const; | ||
| int getSeconds() const; | ||
| int getYears() const; |
There was a problem hiding this comment.
Use two spaces for indentation instead of tab.
|
@thaianhtaivn Actually this was already implemented #94 but not merged :/ |
4 participants
Already tested function with platformIO & ESP8266.