Add WAV file reader. #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iabdalkader
force-pushed
the
wav_reader
branch
from
73eb174 to
1a2bf6c
Compare
|
Memory usage change @ 1a2bf6c
Click for full report table
Click for full report CSV |
iabdalkader
force-pushed
the
wav_reader
branch
3 times, most recently
from
8705889 to
ea93fb0
Compare
|
Memory usage change @ ea93fb0
Click for full report table
Click for full report CSV |
iabdalkader
force-pushed
the
wav_reader
branch
2 times, most recently
from
e89040c to
612a506
Compare
|
Memory usage change @ 612a506
Click for full report table
Click for full report CSV |
iabdalkader
force-pushed
the
wav_reader
branch
from
612a506 to
ed1d15b
Compare
|
Memory usage change @ ed1d15b
Click for full report table
Click for full report CSV |
per1234
added
type: enhancement
There was a problem hiding this comment.
It looks clear and smooth!
Could you add a brief example in the Usage section of docs/README.md and APIs description in the docs/api.md?
iabdalkader
force-pushed
the
wav_reader
branch
2 times, most recently
from
38a0d93 to
bd6a329
Compare
|
Memory usage change @ bd6a329
Click for full report table
Click for full report CSV |
Signed-off-by: iabdalkader <[email protected]>
- Switch to WavReader. - Fix the handling of multi-channels. - Simplify the example code. Signed-off-by: iabdalkader <[email protected]>
iabdalkader
force-pushed
the
wav_reader
branch
from
bd6a329 to
21c3525
Compare
|
Memory usage change @ 21c3525
Click for full report table
Click for full report CSV |
Sure, but it should be documented before the next release, as the API may change slightly in the following PR. |
facchinm
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a WAV file reader as it's about to be used in more examples, so it made sense to move the code to a common class. The WavReader handles parsing the header, reading samples and rewinding the data for audio loops. The playback example is also updated to use the WavReader and I fixed a few issues in the code, including the handling of 2 channels.