WebSocketClient: check extended length/mask bytes are available #203
Open
pennam wants to merge 3 commits into
Open
WebSocketClient: check extended length/mask bytes are available #203pennam wants to merge 3 commits into
pennam wants to merge 3 commits into
Conversation
Multiple read() calls in one expression have unspecified evaluation order in C++, so the length bytes could be combined wrong. Read each byte into its own variable before combining them.
Default iRxSize to the inline length and only override it for the 126/127 extended-length cases. No behavioural change.
Only 2 header bytes were guaranteed before reading the extended length and mask, so a partial header made read() return -1 and corrupt iRxSize. Bail out until all header bytes have arrived.
per1234
added
type: imperfection
|
Memory usage change @ d0a7577
Click for full report table
Click for full report CSV |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only 2 header bytes were guaranteed before reading the extended length and
mask, so a partial header made read() return -1 and corrupt iRxSize. Bail
out until all header bytes have arrived.