Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dapr secret provider #412

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

stijnmoreels
Copy link
Member

Add a secret provider that includes the secrets from the Dapr secret store to the Arcus secret store.

Closes #410

@netlify
Copy link

netlify bot commented Jul 5, 2023

Deploy Preview for arcus-security ready!

Name Link
🔨 Latest commit 013009f
🔍 Latest deploy log https://app.netlify.com/sites/arcus-security/deploys/651a60ea957e8f0008288c15
😎 Deploy Preview https://deploy-preview-412--arcus-security.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stijnmoreels stijnmoreels marked this pull request as ready for review July 5, 2023 15:52
@stijnmoreels stijnmoreels marked this pull request as draft July 5, 2023 15:55
@stijnmoreels stijnmoreels self-assigned this Jul 5, 2023
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d16484a) 89.85% compared to head (e4c9174) 89.85%.
Report is 1 commits behind head on main.

❗ Current head e4c9174 differs from pull request most recent head 013009f. Consider uploading reports for the commit 013009f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #412   +/-   ##
=======================================
  Coverage   89.85%   89.85%           
=======================================
  Files          20       20           
  Lines        1065     1065           
  Branches       82       82           
=======================================
  Hits          957      957           
  Misses         79       79           
  Partials       29       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stijnmoreels stijnmoreels marked this pull request as ready for review July 13, 2023 07:19
@stijnmoreels stijnmoreels changed the title feat: add dapr secret provider (🚧) feat: add dapr secret provider Jul 13, 2023

# Dapr secret provider
Dapr secret provider brings secrets from the Dapr secret store to your application. Dapr is commonly used in Kubernetes environments where there is usually not the same network capabilities as other application environments.
By using this secret provider, you still benefit from all the Arcus secret store features, while still using Dapr as your external secret source.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dapr is not really a secret provider. It has the capabilities to connect to a secret provider and ads a layer of abstraction.
People that are looking for using Dapr will probably understand this, but I'm not sure on how we can improve this text

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should change it to Dapr secret management brings external secrets to your application.? As they talk about 'secret management' in their docs?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the suggestion here, @fgheysels better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Kubernetes secrets / dapr
2 participants