Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only fail on fallback when az servicebus message wasn't tried #442

Conversation

stijnmoreels
Copy link
Member

Only when an incoming Azure Service bus message hasn't gone trhough a matching but failing message handler, should we throw if there were no fallback message handlers registered.

Closes #424

Copy link

netlify bot commented Jun 20, 2024

Deploy Preview for arcus-messaging canceled.

Name Link
🔨 Latest commit ea5e679
🔍 Latest deploy log https://app.netlify.com/sites/arcus-messaging/deploys/66745200606c18000867dab5

Copy link
Member

@fgheysels fgheysels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I like the approach of returning as soon as the message was processed.

@stijnmoreels stijnmoreels merged commit d2dc571 into arcus-azure:main Jun 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not using a Fallbackhandler should be a valid use case and not throw an exception.
2 participants