chore: use built-in service bus client in message pump (🚧) #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for arcus-messaging canceled.
|
Bc I'm still working on it, as the tests were failing and it was late so I hadn't time to look into them. 😄 But I wanted to push my changes nonetheless so I would be reminded that I still need to work on this. So, thx! 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the default registration of the
ServiceBusClientto use in the Azure Service Bus message pump. This is somewhat related to the #411 to get aServiceBusSenderin a more easier way; but is also a performance improvement as the host will now handle the connection for us instead of the message pump (which was re-creating the client in some cases of restart).Relates to #411