Merged
Conversation
- Add claude.yml: Respond to @claude mentions in issues/PRs - Add claude-code-review.yml: Automated PR code reviews - Follows ARC Labs Swift standards - Configured with CLAUDE_CODE_OAUTH_TOKEN secret
* feat(skills): add worktrees workflow skill for parallel development * feat(skills): add memory and worktrees workflow skills * docs(skills): add skills index for iOS/Swift development Create comprehensive skills index document that maps when to use each skill source (ARC Labs, Van der Lee, Axiom) for iOS/Swift development tasks. Includes quick decision guide, coverage gaps matrix, and common scenario recommendations. * feat(skills): add iOS 26 Liquid Glass and @Previewable patterns Update arc-presentation-layer skill with: - iOS 26 Liquid Glass material effects (.glassEffect modifier) - Backward compatible glass implementations - Glass effect tinting patterns - Toolbar Liquid Glass treatment - @Previewable macro for SwiftUI previews (iOS 18+) - Preview best practices with multiple states - Updated related skills table with Axiom iOS 26 references * feat(skills): add memory and worktrees workflow skills
Add comprehensive final review skill inspired by Staff iOS Engineer review patterns. The skill: - Analyzes changes by domain (SwiftUI, Concurrency, Data, Architecture) - Invokes specialized Axiom skills for each domain - Generates prioritized finalization plan with verification gates - Identifies tech debt cleanup items - Provides merge recommendation Also updates CLAUDE.md to document the new skill in the workflow.
FVRS-73 Clean Architecture audit documented key patterns: Testing: - @mainactor isolation requirements for test structs - Mock extension isolation for Swift 6 compatibility - Tag centralization to avoid "ambiguous use" errors - Mock factory best practices (avoiding false matches) Presentation: - @observable + lazy var incompatibility (use IUOs + init) - Composition Root pattern for AppCoordinator DI Architecture: - ISP: Reader/Writer protocol separation for repositories - Pure Use Cases (stateless, no dependencies) - Real-world FVRS-73 ISP example with Toggle/Get/Filter use cases
* docs(standards): rewrite CLAUDE.md with comprehensive agent guide - Add presentation layer rules (no business logic in Views or ViewModels) - Add UseCase patterns (single-responsibility + grouped with enum actions) - Add concurrency guidelines (@mainactor per-method only, never blanket) - Add multiline declaration formatting (after-first style) - Add private extension pattern for private methods - Add ARCKnowledge access configuration via submodule chain - Add complementary skills section (Axiom, Van der Lee, MCP Cupertino) - Update critical rules from 13 to 15 - Add periodic review section with /arc-audit * docs(architecture): update ViewModel, UseCase and concurrency patterns - Remove blanket @mainactor from ViewModel examples - Add @mainactor per-method on UI-bound state methods only - Add Sendable conformance to UseCase protocols and implementations - Add grouped UseCase pattern with enum actions - Add concurrency guidelines section (WWDC 2025-268) - Update anti-patterns list * docs(presentation): apply @mainactor per-method to ViewModel examples - Remove blanket @mainactor from UserProfileViewModel - Add @mainactor to onAppear(), onTappedRetry(), loadProfile() methods - Remove blanket @mainactor from ContentViewModel and HomeViewModel - Update description to emphasize ViewModels contain NO business logic * docs(testing): add mandatory UseCase testing and update ViewModel tests - Add "Testing Use Cases (Mandatory)" section with full example - Update ViewModel test examples: @mainactor per-method, not on @suite - Cover business rules, error paths, and validation in UseCase tests * docs(quality): add multiline formatting and private extension patterns - Add multiline declarations section (after-first style) - Add private extension pattern section - Update SwiftFormat config with --wrapparameters, --wrapcollections, --closingparen balanced - Update MARK section ordering in code-style.md - Remove redundant private extension for String type * docs(domain): add grouped UseCase pattern and Sendable conformance - Add grouped UseCase pattern with enum actions - Add Sendable conformance to UseCase protocol and implementation - Move private methods to private extension pattern - Add testing requirement for all UseCases - Update Domain Layer checklist with new requirements - Update MARK sections to new standard * docs(review): update checklists for @mainactor per-method and Sendable - Fix Architecture Checklist: no blanket @mainactor on ViewModels - Fix Concurrency Checklist: @mainactor per-method, Sendable on UseCases - Add private extension and UseCase testing checks * feat(skills): create /arc-audit skill for project standards compliance New comprehensive audit skill with: - 9 audit domains (Architecture, Presentation, Domain, Data, Testing, Code Style, Documentation, Accessibility, Concurrency) - Compliance grading (A-F) with severity levels - Scope support (full project, directory, single file) - Scan commands and patterns for each domain - Report template with findings and recommendations - Integration with complementary Axiom and ARC Labs skills * docs(index): add /arc-audit and /arc-final-review to skills index - Add /arc-audit and /arc-final-review to ARC Labs skills table - Add project standards audit to Quick Decision Guide - Update ARC Labs version info to Feb 2026
* refactor(skills): align arc-final-review with Anthropic skill guide Rewrite description field with trigger phrases, add metadata block, rename section headings, and add Examples section. * refactor(skills): align arc-audit with Anthropic skill guide Rewrite description field with trigger phrases, add metadata block, rename section headings, and add Examples section. * refactor(skills): align arc-memory with Anthropic skill guide Rewrite description field with trigger phrases, add metadata block, rename section headings, and add Examples section. * refactor(skills): align arc-worktrees-workflow with Anthropic skill guide Rewrite description field with trigger phrases, add metadata block, rename section headings, and add Examples section. * refactor(skills): align arc-data-layer with Anthropic skill guide Rewrite description field with trigger phrases, add metadata block, rename section headings, add Examples section, and move data.md to references/ subdirectory for progressive disclosure. * refactor(skills): align arc-tdd-patterns with Anthropic skill guide Rewrite description field with trigger phrases, add metadata block, rename section headings, add Examples section, and move testing.md to references/ subdirectory for progressive disclosure. * refactor(skills): align arc-presentation-layer with Anthropic skill guide Rewrite description field with trigger phrases, add metadata block, rename section headings, add Examples section, and move presentation.md to references/ subdirectory for progressive disclosure. * refactor(skills): align arc-workflow with Anthropic skill guide Rewrite description field with trigger phrases, add metadata block, rename section headings, add Examples section, and move git-branches.md, git-commits.md, plan-mode.md to references/ subdirectory. * refactor(skills): align arc-swift-architecture with Anthropic skill guide Rewrite description field with trigger phrases, add metadata block, rename section headings, add Examples section, and move 6 supplemental files to references/ subdirectory for progressive disclosure. * refactor(skills): align arc-quality-standards with Anthropic skill guide Rewrite description field with trigger phrases, add metadata block, rename section headings, add Examples section, and move 6 supplemental files to references/ subdirectory for progressive disclosure. * refactor(skills): align arc-project-setup with Anthropic skill guide Rewrite description field with trigger phrases, add metadata block, rename section headings, add Examples section, and move 5 supplemental files to references/ subdirectory for progressive disclosure.
* feat(ci): add arc-xcode-cloud skill and update skills index - Add .claude/skills/arc-xcode-cloud/SKILL.md with full Xcode Cloud setup guide - Update Skills/skills-index.md to include arc-xcode-cloud - Update Tools/xcode.md with Xcode Cloud section - Update CLAUDE.md skills table to include arc-xcode-cloud * docs: add arc-xcode-cloud to README skills table and documentation index
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.