Netx 184 clear stuck packets when there is a success event seen #73
pr-validation.yaml
on: pull_request
Run ReviewDog
2m 17s
Tests
2m 5s
Annotations
41 errors and 2 warnings
[GolangCI Lint] pkg/collector/ibc_collector.go#L215:
pkg/collector/ibc_collector.go#L215
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
[GolangCI Lint] pkg/collector/ibc_collector.go#L218:
pkg/collector/ibc_collector.go#L218
File is not `gofumpt`-ed with `-extra` (gofumpt)
|
[GolangCI Lint] pkg/collector/ibc_collector.go#L238:
pkg/collector/ibc_collector.go#L238
ineffectual assignment to newAckHeight (ineffassign)
|
[GolangCI Lint] pkg/collector/ibc_collector.go#L240:
pkg/collector/ibc_collector.go#L240
File is not `gofumpt`-ed with `-extra` (gofumpt)
|
[GolangCI Lint] pkg/collector/ibc_collector.go#L249:
pkg/collector/ibc_collector.go#L249
assignments should only be cuddled with other assignments (wsl)
|
[GolangCI Lint] pkg/collector/ibc_collector.go#L252:
pkg/collector/ibc_collector.go#L252
block should not end with a whitespace (or comment) (wsl)
|
[GolangCI Lint] pkg/collector/ibc_collector.go#L255:
pkg/collector/ibc_collector.go#L255
ineffectual assignment to newAckHeight (ineffassign)
|
[GolangCI Lint] pkg/collector/ibc_collector.go#L257:
pkg/collector/ibc_collector.go#L257
File is not `gofumpt`-ed with `-extra` (gofumpt)
|
[GolangCI Lint] pkg/collector/ibc_collector.go#L314:
pkg/collector/ibc_collector.go#L314
commentFormatting: put a space between `//` and comment text (gocritic)
|
[GolangCI Lint] pkg/collector/ibc_collector.go#L325:
pkg/collector/ibc_collector.go#L325
assignments should only be cuddled with other assignments (wsl)
|
[GolangCI Lint] pkg/collector/ibc_collector.go#L332:
pkg/collector/ibc_collector.go#L332
ineffectual assignment to newAckHeight (ineffassign)
|
[GolangCI Lint] pkg/collector/ibc_collector.go#L334:
pkg/collector/ibc_collector.go#L334
File is not `gofumpt`-ed with `-extra` (gofumpt)
|
[GolangCI Lint] pkg/ibc/ibc.go#L204:
pkg/ibc/ibc.go#L204
expressions should not be cuddled with declarations or returns (wsl)
|
[GolangCI Lint] pkg/ibc/ibc.go#L205:
pkg/ibc/ibc.go#L205
only one cuddle assignment allowed before go statement (wsl)
|
[GolangCI Lint] pkg/ibc/ibc.go#L207:
pkg/ibc/ibc.go#L207
declarations should never be cuddled (wsl)
|
[GolangCI Lint] pkg/ibc/ibc.go#L211:
pkg/ibc/ibc.go#L211
if statements should only be cuddled with assignments (wsl)
|
[GolangCI Lint] pkg/ibc/ibc.go#L239:
pkg/ibc/ibc.go#L239
return statements should not be cuddled if block has more than two lines (wsl)
|
[GolangCI Lint] pkg/ibc/ibc.go#L249:
pkg/ibc/ibc.go#L249
declarations should never be cuddled (wsl)
|
[GolangCI Lint] pkg/ibc/ibc.go#L253:
pkg/ibc/ibc.go#L253
if statements should only be cuddled with assignments (wsl)
|
[GolangCI Lint] pkg/ibc/ibc.go#L280:
pkg/ibc/ibc.go#L280
return statements should not be cuddled if block has more than two lines (wsl)
|
[GolangCI Lint] pkg/ibc/ibc.go#L290:
pkg/ibc/ibc.go#L290
File is not `gofumpt`-ed with `-extra` (gofumpt)
|
[GolangCI Lint] pkg/ibc/ibc.go#L296:
pkg/ibc/ibc.go#L296
go statements can only invoke functions assigned on line above (wsl)
|
[GolangCI Lint] pkg/ibc/ibc.go#L326:
pkg/ibc/ibc.go#L326
go statements can only invoke functions assigned on line above (wsl)
|
[GolangCI Lint] pkg/ibc/ibc.go#L350:
pkg/ibc/ibc.go#L350
return statements should not be cuddled if block has more than two lines (wsl)
|
[GolangCI Lint] pkg/ibc/ibc.go#L354:
pkg/ibc/ibc.go#L354
expressions should not be cuddled with blocks (wsl)
|
[GolangCI Lint] pkg/ibc/ibc.go#L360:
pkg/ibc/ibc.go#L360
return statements should not be cuddled if block has more than two lines (wsl)
|
[GolangCI Lint] pkg/ibc/ibc.go#L367:
pkg/ibc/ibc.go#L367
go statements can only invoke functions assigned on line above (wsl)
|
[GolangCI Lint] pkg/ibc/ibc.go#L369:
pkg/ibc/ibc.go#L369
assignments should only be cuddled with other assignments (wsl)
|
[GolangCI Lint] pkg/ibc/ibc.go#L370:
pkg/ibc/ibc.go#L370
only one cuddle assignment allowed before if statement (wsl)
|
[GolangCI Lint] pkg/ibc/ibc.go#L377:
pkg/ibc/ibc.go#L377
return statements should not be cuddled if block has more than two lines (wsl)
|
[GolangCI Lint] pkg/ibc/ibc.go#L391:
pkg/ibc/ibc.go#L391
go statements can only invoke functions assigned on line above (wsl)
|
[GolangCI Lint] pkg/ibc/ibc.go#L393:
pkg/ibc/ibc.go#L393
assignments should only be cuddled with other assignments (wsl)
|
[GolangCI Lint] pkg/ibc/ibc.go#L394:
pkg/ibc/ibc.go#L394
only one cuddle assignment allowed before if statement (wsl)
|
[GolangCI Lint] pkg/ibc/ibc.go#L401:
pkg/ibc/ibc.go#L401
return statements should not be cuddled if block has more than two lines (wsl)
|
[GolangCI Lint] pkg/ibc/ibc.go#L412:
pkg/ibc/ibc.go#L412
expressions should not be cuddled with blocks (wsl)
|
[GolangCI Lint] pkg/ibc/ibc.go#L417:
pkg/ibc/ibc.go#L417
unused-parameter: parameter 'newAckHeight' seems to be unused, consider removing or renaming it as _ (revive)
|
[GolangCI Lint] pkg/ibc/ibc.go#L419:
pkg/ibc/ibc.go#L419
var-declaration: should omit type int64 from declaration of var lastQueriedBlockHeight; it will be inferred from the right-hand side (revive)
|
[GolangCI Lint] pkg/ibc/ibc.go#L447:
pkg/ibc/ibc.go#L447
File is not `gofumpt`-ed with `-extra` (gofumpt)
|
[GolangCI Lint] pkg/ibc/ibc.go#L464:
pkg/ibc/ibc.go#L464
assignOp: replace `lastQueriedBlockHeight = lastQueriedBlockHeight + 1` with `lastQueriedBlockHeight++` (gocritic)
|
[GolangCI Lint] pkg/ibc/ibc.go#L465:
pkg/ibc/ibc.go#L465
only one cuddle assignment allowed before range statement (wsl)
|
Run ReviewDog
reviewdog exited with status code: 1
|
Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-go@v4. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Run ReviewDog
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, reviewdog/action-golangci-lint@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|