Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(x/cwerrors): send fees from the sender account instead of contract account #562

Merged
merged 2 commits into from
Apr 19, 2024
Merged

fix(x/cwerrors): send fees from the sender account instead of contract account #562

merged 2 commits into from
Apr 19, 2024

Conversation

spoo-bar
Copy link
Contributor

when cwerrors subscription was being set, the fees was deducted from the contract account instead of the sender address

@spoo-bar spoo-bar marked this pull request as ready for review April 19, 2024 05:59
@spoo-bar spoo-bar requested a review from a team as a code owner April 19, 2024 05:59
zanicar
zanicar approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@zanicar zanicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spoo-bar spoo-bar merged commit c2f92ce into main Apr 19, 2024
8 of 9 checks passed
@spoo-bar spoo-bar deleted the spoorthi/fix-error-where-cwerror-subscription-was-being-deducted-from-contract branch April 19, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanicar zanicar zanicar approved these changes

@fdymylja fdymylja Awaiting requested review from fdymylja fdymylja is a code owner automatically assigned from archway-network/protocol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spoo-bar @zanicar