Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update changelog #426

Merged
merged 2 commits into from
Aug 11, 2023
Merged

chore: Update changelog #426

merged 2 commits into from
Aug 11, 2023

Conversation

zanicar
Copy link
Contributor

@zanicar zanicar commented Aug 10, 2023

Preparation for tagging v3

@zanicar zanicar marked this pull request as ready for review August 10, 2023 13:53
@zanicar zanicar requested a review from a team as a code owner August 10, 2023 13:53
@zanicar zanicar requested a review from fdymylja August 10, 2023 13:53
spoo-bar
spoo-bar suggested changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@spoo-bar spoo-bar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would need upgrade handler for v3 as well

@zanicar zanicar requested a review from spoo-bar August 11, 2023 11:22
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6abd9cc) 69.54% compared to head (ef667b5) 69.54%.
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #426   +/-   ##
=======================================
  Coverage   69.54%   69.54%           
=======================================
  Files          67       67           
  Lines        4006     4006           
=======================================
  Hits         2786     2786           
  Misses       1124     1124           
  Partials       96       96
Files Changed Coverage Δ
app/app_upgrades.go 61.90% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zanicar zanicar merged commit 84aeeef into main Aug 11, 2023
6 checks passed
@zanicar zanicar deleted the zanicar/v3 branch August 11, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spoo-bar spoo-bar spoo-bar approved these changes

@fdymylja fdymylja Awaiting requested review from fdymylja fdymylja is a code owner automatically assigned from archway-network/protocol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zanicar @spoo-bar