Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(x/rewards): Add fee burn #422

Merged
merged 6 commits into from
Jul 27, 2023
Merged

feat(x/rewards): Add fee burn #422

merged 6 commits into from
Jul 27, 2023

Conversation

fdymylja
Copy link
Contributor

This PR adds fee burning on TX fees which are not distributed to contracts.

@fdymylja fdymylja requested a review from a team as a code owner July 20, 2023 13:10
@fdymylja fdymylja requested a review from spoo-bar July 20, 2023 13:10
@codecov
Copy link

codecov bot commented Jul 20, 2023 •
edited
Loading

Codecov Report

Patch coverage: 72.72% and project coverage change: -0.05% ⚠️

Comparison is base (d6c5cf4) 69.59% compared to head (7a2f211) 69.54%.
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #422      +/-   ##
==========================================
- Coverage   69.59%   69.54%   -0.05%     
==========================================
  Files          67       67              
  Lines        4002     4006       +4     
==========================================
+ Hits         2785     2786       +1     
- Misses       1122     1124       +2     
- Partials       95       96       +1
Files Changed Coverage Δ
x/rewards/ante/fee_deduction.go 54.94% <25.00%> (-1.88%) ⬇️
app/ante.go 58.82% <100.00%> (ø)
app/app.go 90.62% <100.00%> (+0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zanicar
zanicar approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@zanicar zanicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

spoo-bar
spoo-bar reviewed Jul 24, 2023
View reviewed changes
app/ante.go Outdated Show resolved Hide resolved
app/app.go Outdated Show resolved Hide resolved
zanicar
zanicar approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@zanicar zanicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

spoo-bar
spoo-bar approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@spoo-bar spoo-bar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

We should also update ADR about this

zanicar
zanicar approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@zanicar zanicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanicar zanicar merged commit 6abd9cc into main Jul 27, 2023
6 checks passed
@zanicar zanicar deleted the fd/fee_burn branch July 27, 2023 09:11
@spoo-bar spoo-bar mentioned this pull request Aug 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spoo-bar spoo-bar spoo-bar approved these changes

@zanicar zanicar zanicar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fdymylja @spoo-bar @zanicar