Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable ica module #416

Merged
merged 9 commits into from
Jul 10, 2023
Merged

feat: enable ica module #416

merged 9 commits into from
Jul 10, 2023

Conversation

spoo-bar
Copy link
Contributor

@spoo-bar spoo-bar commented Jul 6, 2023 •
edited
Loading

  • Enabling ICA Host module with the following msgs allowed
    • banktypes.MsgSend
    • banktypes.MsgMultiSend
    • stakingtypes.MsgDelegate
    • stakingtypes.MsgUndelegate
    • stakingtypes.MsgBeginRedelegate
    • stakingtypes.MsgCreateValidator
    • stakingtypes.MsgEditValidator
    • distrtypes.MsgWithdrawDelegatorReward
    • distrtypes.MsgSetWithdrawAddress
    • distrtypes.MsgWithdrawValidatorCommission
    • distrtypes.MsgFundCommunityPool
    • govtypes.MsgVote
    • govtypes.MsgVoteWeighted

@codecov
Copy link

codecov bot commented Jul 6, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.19 🎉

Comparison is base (ee212ab) 69.39% compared to head (644758c) 69.59%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #416      +/-   ##
==========================================
+ Coverage   69.39%   69.59%   +0.19%     
==========================================
  Files          67       67              
  Lines        3976     4002      +26     
==========================================
+ Hits         2759     2785      +26     
  Misses       1122     1122              
  Partials       95       95
Impacted Files Coverage Δ
app/app_upgrades.go 61.90% <ø> (ø)
app/app.go 90.60% <100.00%> (+0.42%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@spoo-bar spoo-bar marked this pull request as ready for review July 10, 2023 08:40
@spoo-bar spoo-bar requested a review from a team as a code owner July 10, 2023 08:40
@spoo-bar spoo-bar requested a review from zanicar July 10, 2023 08:40
zanicar
zanicar approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@zanicar zanicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spoo-bar spoo-bar merged commit d6c5cf4 into main Jul 10, 2023
6 checks passed
@spoo-bar spoo-bar deleted the spoorthi/adding-ica- branch July 10, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanicar zanicar zanicar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spoo-bar @zanicar