Install cssmin using poetry compatible URL
#321
Conversation
`poetry` doesn't support `requirements.txt` directly, but this works
cat requirements.txt | xargs poetry add
|
Do you know a more modern css minifier which can be integrated in django? |
|
Plenty of choice there https://pypi.org/search/?q=css+minifier Never used one. |
| @@ -1,4 +1,4 @@ | |||
| -e git+git://github.com/fredj/cssmin.git@master#egg=cssmin | |||
| git+https://github.com/fredj/cssmin.git | |||
There was a problem hiding this comment.
Reading the documentation it seems for pip #egg=cssmin is required so can't it be kept? Why would poetry not understand something pip makes up?
There was a problem hiding this comment.
I think the point was removing the -e which poetry can't handle, not sure why the egg spec is being removed.
There was a problem hiding this comment.
Just tested it and poetry can't handle that @master either which is rather sad
There was a problem hiding this comment.
I would raise an issue with pip for deprecating #egg=cssmin suffix that looks like a hack.
There was a problem hiding this comment.
It is absolutely not. And it is already deprecated as eggs themselves are deprecated.
https://pip.pypa.io/en/stable/reference/pip_install/#vcs-support
There was a problem hiding this comment.
Press 😄 if #egg is a hack, and 🎉 if it is not. )
There was a problem hiding this comment.
It's fine to argue if this is or is not a hack, but please do not go open issues for features very deliberately documented. This is open source and I assure you all the pip maintainers, as is usual on open source projects, are busy, you will only be wasting their already limited time.
There was a problem hiding this comment.
I am using poetry. So, what is the consensus Are you going to merge this? )
poetrydoesn't supportrequirements.txtdirectly, but this worksMaybe consider switching to some more modern supported library.