Skip to content

fix: only prompt for credentials encryption when creds will be saved #4720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NWuensche wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: only prompt for credentials encryption when creds will be saved #4720

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 18 additions & 16 deletions archinstall/lib/configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,24 +109,26 @@ def preview(item: MenuItem) -> str | None:

debug(f'Saving configuration files to {dest_path.absolute()}')

header = tr('Do you want to encrypt the user_credentials.json file?')
enc_password: str | None = None

enc_result = await Confirmation(
header=header,
allow_skip=False,
preset=False,
).show()
if save_option in ('user_creds', 'all'):
header = tr('Do you want to encrypt the user_credentials.json file?')

enc_password: str | None = None
if enc_result.type_ == ResultType.Selection:
if enc_result.get_value():
password = await get_password(
header=tr('Credentials file encryption password'),
allow_skip=True,
)

if password:
enc_password = password.plaintext
enc_result = await Confirmation(
header=header,
allow_skip=False,
preset=False,
).show()

if enc_result.type_ == ResultType.Selection:
if enc_result.get_value():
password = await get_password(
header=tr('Credentials file encryption password'),
allow_skip=True,
)

if password:
enc_password = password.plaintext

match save_option:
case 'user_config':
Expand Down