Add new option to ignore file timestamps and produce archives with consistent hash #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ctalkington , any progress on this PR? |
ctalkington
reviewed
Jul 26, 2021
| @@ -153,6 +153,44 @@ describe('archiver', function() { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('#options.noTimestamp', function() { | |||
There was a problem hiding this comment.
Suggested change
| describe('#options.noTimestamp', function() { | |
| describe('options.noTimestamps', function() { |
|
Hey @ctalkington, are there any updates, or has this functionality already been implemented in some other way? |
|
This would be a very useful feature to have when building with Bazel, which relies on deterministic artifacts for good remote cache performance. |
|
Note that I was able to work around this by fixing the date in the file entry when appending to a zip: zip.append(content, {name: "foo.txt", date: new Date(0)}); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the following issue
#416