Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support newer versions of MinecraftForge 1.20.2. #164

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

shedaniel
Copy link
Member

@shedaniel shedaniel commented Oct 23, 2023

Not sure if that's the best place to put the MOD_CLASSES envvar.
Tested working with 48.0.17 and above.

Forge since 48.0.14 tests jars starting with "client-extra", this PR renames that jar, not sure if renaming the forge-client-extra.jar breaks older versions

Side Effect: This invalidates all current Forge projects, so I am not sure if we really want to rename this jar for everyone

image

@shedaniel shedaniel added the Forge This issue is specific to the Forge platform. label Oct 23, 2023
@github-actions
Copy link

github-actions bot commented Oct 23, 2023

Test Results

  91 files   - 1      1 errors  90 suites   - 1   3h 21m 53s ⏱️ - 39m 22s
494 tests  - 1  493 ✔️  - 1  0 💤  - 1  1 +1 
501 runs  +3  500 ✔️ +3  0 💤  - 1  1 +1 

For more details on these parsing errors and failures, see this check.

Results for commit 9d37bb1. ± Comparison against base commit b6354a0.

This pull request removes 21 and adds 9 tests. Note that renamed tests count towards both.

 '
Fabric-Loom-Remap: broken
Fabric-Loom-Remap: false
Fabric-Loom-Remap: true
Something: Hello
], #1]
], #2]
], #3]
], #4]
…
net.fabricmc.loom.test.unit.ArtifactMetadataTest ‑ Should Remap [shouldRemap: false, entries: [fabric.mod.json:{}, META-INF/MANIFEST.MF:Manifest-Version: 1.0
Fabric-Loom-Remap: false

], #2]
net.fabricmc.loom.test.unit.ArtifactMetadataTest ‑ Should Remap [shouldRemap: false, entries: [hello.json:{}, META-INF/MANIFEST.MF:Manifest-Version: 1.0
Fabric-Loom-Remap: broken

], #6]
net.fabricmc.loom.test.unit.ArtifactMetadataTest ‑ Should Remap [shouldRemap: false, entries: [hello.json:{}, META-INF/MANIFEST.MF:Manifest-Version: 1.0
Fabric-Loom-Remap: false

], #4]
net.fabricmc.loom.test.unit.ArtifactMetadataTest ‑ Should Remap [shouldRemap: false, entries: [hello.json:{}, META-INF/MANIFEST.MF:Manifest-Version: 1.0
Something: Hello

], #7]
net.fabricmc.loom.test.unit.ArtifactMetadataTest ‑ Should Remap [shouldRemap: true, entries: [fabric.mod.json:{}, META-INF/MANIFEST.MF:Manifest-Version: 1.0
Fabric-Loom-Remap: true

], #3]
net.fabricmc.loom.test.unit.ArtifactMetadataTest ‑ Should Remap [shouldRemap: true, entries: [hello.json:{}, META-INF/MANIFEST.MF:Manifest-Version: 1.0
Fabric-Loom-Remap: true

], #5]
net.fabricmc.loom.test.unit.ArtifactMetadataTest ‑ remap requirements [requirements: OPT_IN, entries: [META-INF/MANIFEST.MF:Manifest-Version: 1.0
Fabric-Loom-Remap: true

], #2]
net.fabricmc.loom.test.unit.ArtifactMetadataTest ‑ remap requirements [requirements: OPT_OUT, entries: [META-INF/MANIFEST.MF:Manifest-Version: 1.0
Fabric-Loom-Remap: false

], #1]
net.fabricmc.loom.test.unit.StringsTest ‑ capitalize ' 
 '

♻️ This comment has been updated with latest results.

@shedaniel shedaniel changed the base branch from dev/1.3 to dev/1.4 October 24, 2023 03:22
@shedaniel shedaniel merged commit 48c3961 into dev/1.4 Oct 24, 2023
2 checks passed
@shedaniel shedaniel deleted the feature/new_lexforge_1202 branch October 24, 2023 03:22
ejektaflex added a commit to ejektaflex/Kambrik that referenced this pull request Oct 24, 2023
Updating ArchLoom to 1.4-Snapshot fixed the Forge issue, as per a thread on the Architectury Discord.
See: architectury/architectury-loom#164
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Forge This issue is specific to the Forge platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants