Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add artifact metadata source to Forge Maven repo #10

Open
wants to merge 1 commit into
base: dev/0.6-forge
Choose a base branch
from

Conversation

Polaris257
Copy link

MCP snapshot 20200514 does not have a .pom like 20201028, so artifact() must be added as a metadata source.

20200514 gives a 404:

https://files.minecraftforge.net/maven/de/oceanlabs/mcp/mcp_snapshot/20200514-1.16.3/mcp_snapshot-20200514-1.16.3.pom

20201028 is valid:

https://files.minecraftforge.net/maven/de/oceanlabs/mcp/mcp_snapshot/20201028-1.16.3/mcp_snapshot-20201028-1.16.3.pom

Adding artifact() allows 20200514 to be used like so:

mappings group: "de.oceanlabs.mcp", name: "mcp_snapshot", version: "20200514-1.16.3", ext: "zip"

(ext: "zip" is required because otherwise Gradle looks for a .jar. This is equivalent to <packaging>zip</packaging> in mcp_snapshot-20201028-1.16.3.pom.)

@shedaniel
Copy link
Member

Is it only 20200514 that suffers from this, if so, is 20200514 a problem build?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants