Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: match note name without quotes #254

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Fjorge0
Copy link
Contributor

@Fjorge0 Fjorge0 commented Sep 30, 2023

I did some testing of the modified regexp and as you can see it works fine

image
image
image

Copy link
Collaborator

@anna328p anna328p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matches on invalid inputs

"foo "bar" baz => name: foo "bar, text: baz
'foo'bar' baz => name: foo'bar, text: baz
'foo'bar baz => name: 'foo'bar, text: baz

fails to capture multiline text

"foo" bar
baz

=> name: foo, text: bar

@Fjorge0
Copy link
Contributor Author

Fjorge0 commented Oct 3, 2023

The updated version passes your provided examples:
image
image

For the original test notes, it behaves the same, with the exception of the adventure time one:
image

@Fjorge0 Fjorge0 requested a review from anna328p October 3, 2023 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants