Use attributes Nextcloud for controllers #1362
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarinier
requested changes
Aug 11, 2025
Collaborator
There was a problem hiding this comment.
The server PHP minimum version requirement can only be done by Nextcloud itself.
You can't add 8.0 features in NC25 dependency APP. This would block a server using NC25 with PHp 7.4.
his improvments can only be pushed since NC26. So, this can only be done on 4.1 branch.
zak39
force-pushed
the
refactor/use-attributes-nc
branch
from
10820aa to
6000a50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OP#3200