Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ctest execute fail，remove duplicate ci #57

Merged
merged 2 commits into from
Oct 19, 2024
Merged

fix: ctest execute fail，remove duplicate ci #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4156d90
fix ctest execute fail，remove duplicate ci
lqxhub Oct 12, 2024
9910025
modify ctest
lqxhub Oct 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/import_braft.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ name: Import BRaft Actions (Temporary)

on:
push:
branches: [ "import-braft" ]
pull_request:
branches: [ "import-braft" ]

Expand Down
12 changes: 8 additions & 4 deletions .github/workflows/pikiwidb.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,13 @@ name: kiwi

on:
push:
branches: [ "unstable" ]
pull_request:
branches: [ "unstable" ]

env:
BUILD_DIR: cmake-build-release
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Inconsistent usage of BUILD_DIR identified

The environment variable BUILD_TYPE is still used in the following lines and should be updated to BUILD_DIR for consistency:

  • Line 40
  • Line 51
  • Line 71
  • Line 82
🔗 Analysis chain

Verify consistent usage of BUILD_DIR throughout the file

To ensure all instances of the environment variable are correctly updated, please run the following verification:

If the command returns any results, those lines should be updated to use BUILD_DIR instead of BUILD_TYPE. This will maintain consistency with the environment variable definition at the top of the file.

Also applies to: 40-40, 51-51, 71-71, 82-82

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for any remaining instances of BUILD_TYPE in the workflow file
rg --type yaml 'BUILD_TYPE' .github/workflows/pikiwidb.yml

Length of output: 350


jobs:
check_format:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -33,7 +37,7 @@ jobs:
bash ./etc/script/build.sh --verbose

- name: GTest
working-directory: ${{ github.workspace }}/build-release
working-directory: ${{ github.workspace }}/${{ env.BUILD_DIR }}
# Execute tests defined by the CMake configuration.
# See https://cmake.org/cmake/help/latest/manual/ctest.1.html for more detail
run: ctest
Expand All @@ -44,7 +48,7 @@ jobs:
./etc/script/kiwitests.sh all

- name: Run Go E2E Tests
working-directory: ${{ github.workspace }}/build-release
working-directory: ${{ github.workspace }}/${{ env.BUILD_DIR }}
run: |
set +e
cd ../tests
Expand All @@ -64,7 +68,7 @@ jobs:
bash ./etc/script/build.sh --verbose

- name: GTest
working-directory: ${{ github.workspace }}/build-release
working-directory: ${{ github.workspace }}/${{ env.BUILD_DIR }}
# Execute tests defined by the CMake configuration.
# See https://cmake.org/cmake/help/latest/manual/ctest.1.html for more detail
run: ctest
Expand All @@ -75,7 +79,7 @@ jobs:
./etc/script/kiwitests.sh all

- name: Run Go E2E Tests
working-directory: ${{ github.workspace }}/build-release
working-directory: ${{ github.workspace }}/${{ env.BUILD_DIR }}
run: |
set +e
cd ../tests
Expand Down
Loading