Fix strings being used as a numerical value #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`$font_size` holds the font size as a string, e.g. (`"12px !important;"`), but is being used in calculations such as `$_font_size * 1.5`. On PHP 7+ this will give a notice. For calculations, the numerical value stored in `$_font_size` or `CrayonGlobalSettings::get(CrayonSettings::FONT_SIZE))->def()` should be used instead. Fixes one of the issues reported in https://wordpress.org/support/topic/failed-to-open-stream-error-when-creating-new-post/#post-8663430
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$font_sizeholds the font size as a string, e.g. ("12px !important;"), but is being used in calculations such as$_font_size * 1.5. On PHP 7+ this will give a notice. For calculations, the numerical value stored in$_font_sizeorCrayonGlobalSettings::get(CrayonSettings::FONT_SIZE))->def()should be used instead.Fixes one of the issues reported in https://wordpress.org/support/topic/failed-to-open-stream-error-when-creating-new-post/#post-8663430