Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] OASIS-to-BIDS is not up to date with online data #1321

Merged
merged 6 commits into from
Oct 10, 2024

Conversation

AliceJoubert
Copy link
Contributor

@AliceJoubert AliceJoubert commented Oct 9, 2024

Closes #1314

(Other PR needed for CI data)

@AliceJoubert AliceJoubert added bug Something isn't working converter labels Oct 9, 2024
@AliceJoubert AliceJoubert self-assigned this Oct 9, 2024
@AliceJoubert AliceJoubert marked this pull request as ready for review October 9, 2024 14:35
Copy link
Member

@NicolasGensollen NicolasGensollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AliceJoubert !

test/unittests/iotools/test_bids_utils.py Show resolved Hide resolved
test/unittests/iotools/test_bids_utils.py Outdated Show resolved Hide resolved
Copy link
Member

@NicolasGensollen NicolasGensollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @AliceJoubert !

@NicolasGensollen NicolasGensollen merged commit 67067b3 into aramis-lab:dev Oct 10, 2024
13 of 15 checks passed
@AliceJoubert AliceJoubert deleted the oasis_update_clinical branch October 10, 2024 08:27
@NicolasGensollen NicolasGensollen added this to the v0.9.2 milestone Oct 24, 2024
NicolasGensollen pushed a commit to NicolasGensollen/clinica that referenced this pull request Oct 24, 2024
* First pass

* Small fix

* Update bids_utils test

* Changes 1'
'

* Make change in oasis utils

* Remove duplicate function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working converter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] OASIS-to-BIDS converter is not up-to-date with online clinical data
2 participants