Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete refactor to use SearchInput #609

Merged
merged 6 commits into from
Nov 5, 2019

Conversation

AquiGorka
Copy link
Contributor

Reference: aragonone/product#196

Update Search inputs functionality (magnifying glass to clear button)

This was intended for Tokens, but it comes with the extra benefit that all AutoComplete components will use the SearchInput.

@auto-assign auto-assign bot requested a review from bpierre October 1, 2019 12:42
@AquiGorka AquiGorka requested a review from sohkai October 1, 2019 12:42
@AquiGorka AquiGorka mentioned this pull request Oct 1, 2019
71 tasks
@stale stale bot added the abandoned label Oct 31, 2019
@aragon aragon deleted a comment from stale bot Oct 31, 2019
@stale stale bot removed the abandoned label Oct 31, 2019
- Press escape to close.
- Typing anything opens the suggestions again.

Also refactored a few things for coding style reasons.
@bpierre bpierre merged commit 22865d6 into newstyle Nov 5, 2019
@bpierre bpierre deleted the feature/autocomplete-search-input branch November 5, 2019 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants