Dropdown & Popover fixes for dimensions and scrolling #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes take into consideration if the wide prop is set or not to compute the min width value for the button, it also refactors the way the caret spacing is considered for the rendered placeholder (adds a container with max width) and updates the ref callback to consider the list items instead of the container (which had spacing applied to it)
71 tasks
bpierre
reviewed
Oct 1, 2019
bpierre
reviewed
Oct 1, 2019
AquiGorka
force-pushed
the
fix/dropdown-popover-dimensions-and-scrolling
branch
from
90bc776 to
6dd256a
Compare
delete-merged-branch
bot
deleted the
fix/dropdown-popover-dimensions-and-scrolling
branch
bpierre
pushed a commit
that referenced
this pull request
Nov 18, 2019
DropDown: add mask for label Popover: use container boundaries to avoid overflow; add scrolling
bpierre
pushed a commit
that referenced
this pull request
Nov 18, 2019
DropDown: add mask for label Popover: use container boundaries to avoid overflow; add scrolling
bpierre
pushed a commit
that referenced
this pull request
Nov 20, 2019
DropDown: add mask for label Popover: use container boundaries to avoid overflow; add scrolling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes fix the following issues (from aragonone/product#196)