Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToastList: wrap in root portal #599

Merged
merged 1 commit into from
Sep 17, 2019
Merged

Conversation

AquiGorka
Copy link
Contributor

Ref: aragonone/product#196
Fixes issue in client where ToastHub was rendering the Toasts at a lower level down the tree from some overlays.

@AquiGorka AquiGorka requested a review from bpierre September 16, 2019 14:35
@AquiGorka AquiGorka mentioned this pull request Sep 16, 2019
71 tasks
Copy link
Contributor

@bpierre bpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AquiGorka AquiGorka merged commit 66b3793 into newstyle Sep 17, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/toast-z-index-mobile branch September 17, 2019 06:08
bpierre pushed a commit that referenced this pull request Nov 18, 2019
bpierre pushed a commit that referenced this pull request Nov 18, 2019
bpierre pushed a commit that referenced this pull request Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants