This repository has been archived by the owner on Sep 16, 2024. It is now read-only.
feat(PE-5458): blocklist contract evaluation #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 18, 2024 08:47
Some contracts are known to cause endless evaluation and brick the service. This prevents evaluation of those contracts via middleware that checks the path for these ids and returns 403 when they are blocklisted. We also avoid evaluating these contracts when checking the ownership.
dtfiedler
commented
Jan 18, 2024
fedellen
approved these changes
Jan 18, 2024
dtfiedler
commented
Jan 18, 2024
Comment on lines
+26
to
+30
| blockListedContractCount | ||
| .labels({ | ||
| contractTxId, | ||
| }) | ||
| .inc(); |
There was a problem hiding this comment.
shows in prometheus metrics (e.g. /arns_metrics) as
# HELP blocklisted_contract_count A contract was blocklisted
# TYPE blocklisted_contract_count counter
blocklisted_contract_count{contractTxId="fbU8Y4NMKKzP4rmAYeYj6tDrVDo9XNbdyq5IZPA31WQ"} 1
fedellen
approved these changes
Jan 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocklist contract evaluation based on env vars.
Comment:
To access
ctx.paramswe must be in a route handler, hence why we attach the blocklist middleware to routes that supportcontractTxIddirectly instead of a global middleware. Should we prefer a global middleware, we would have to parse out thecontractTxIdfromctx.pathvia regex, which has a few edge cases we may not want (e.g. thequeryincludingcontractTxIdfor filtering which does not evaluate the contract, and instead filters outrecordsthat are assigned to thatcontractTxId).