DRAFT: Memory safety

CHANGELOG.md

@@ -8,6 +8,12 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 ### Fixed
 
+- Added msg.reply to all APIs
+
+## [13] - [zh4at_Y_GKJMD3SOkZ5Yx7mG2JRRLc89huEOspPtHq4] - (2025-1-29)
+
+### Fixed
+
 - Removed print with ID in Handler wrapper since ID can be null on dry runs.
 
 ## [12] - [mwCMAjglwV_96oEMEIi5epg_QXElOMzEcLkCUeQyGGo] - (2025-1-28)

src/common/main.lua

@@ -90,6 +90,7 @@ function ant.init()
 		local recipient = msg.Tags.Recipient
 		if msg.From ~= Owner then
 			utils.Send(msg, {
+				Target = msg.From,
 				Action = "Transfer-Error",
 				["Message-Id"] = msg.Id,
 				Error = "Insufficient Balance!",
@@ -108,6 +109,7 @@ function ant.init()
 		local balRes = balances.balance(addressToCheck, msg.Tags["Allow-Unsafe-Addresses"])
 
 		utils.Send(msg, {
+			Target = msg.From,
 			Action = "Balance-Notice",
 			Balance = tostring(balRes),
 			Ticker = Ticker,
@@ -123,13 +125,14 @@ function ant.init()
 			bals[k] = tostring(v)
 		end
 
-		utils.Send(msg, { Data = json.encode(bals) })
+		utils.Send(msg, { Target = msg.From, Data = json.encode(bals) })
 	end)
 
 	createActionHandler(TokenSpecActionMap.TotalSupply, function(msg)
 		assert(msg.From ~= ao.id, "Cannot call Total-Supply from the same process!")
 
 		utils.Send(msg, {
+			Target = msg.From,
 			Action = "Total-Supply",
 			Data = tostring(TotalSupply),
 			Ticker = Ticker,
@@ -149,6 +152,7 @@ function ant.init()
 			Handlers = utils.getHandlerNames(Handlers),
 		}
 		utils.Send(msg, {
+			Target = msg.From,
 			Action = "Info-Notice",
 			Tags = info,
 			Data = json.encode(info),
@@ -225,8 +229,8 @@ function ant.init()
 		return initialize.initializeANTState(msg.Data)
 	end)
 
-	createActionHandler(ActionMap.State, function(msg)
-		notices.notifyState(msg, msg.From)
+	createActionHandler(ActionMap.State, function()
+		return utils.getState()
 	end)
 
 	-- IO Network Contract Handlers
@@ -248,7 +252,7 @@ function ant.init()
 			Name = name,
 		})
 
-		ao.send({
+		utils.Send(msg, {
 			Target = msg.From,
 			Action = "Release-Name-Notice",
 			Initiator = msg.From,
@@ -275,7 +279,7 @@ function ant.init()
 			["Process-Id"] = antProcessIdToReassign,
 		})
 
-		ao.send({
+		utils.Send(msg, {
 			Target = msg.From,
 			Action = "Reassign-Name-Notice",
 			Initiator = msg.From,
@@ -329,6 +333,7 @@ function ant.init()
 	AOS provides a _boot handler that is designed to load Lua code on boot.
 	This handler OVERRIDES this and replaces it with our ANT state initialization handler.
 
+	NOTE: if we use utils.Send here memory blows up for some reason
 	]]
 	Handlers.once("_boot", function(msg)
 		return msg.Tags.Type == "Process" and Owner == msg.From
@@ -339,28 +344,22 @@ function ant.init()
 				initialize.initializeANTState(msg.Data)
 			end, utils.errorHandler)
 			if not status then
-				utils.Send(
-					msg,
-					notices.addForwardedTags(msg, {
-						Target = Owner,
-						Error = res or "",
-						Data = res or "",
-						Action = "Invalid-Boot-Notice",
-						["Message-Id"] = msg.Id,
-					})
-				)
+				ao.send(notices.addForwardedTags(msg, {
+					Target = Owner,
+					Error = res or "",
+					Data = res or "",
+					Action = "Invalid-Boot-Notice",
+					["Message-Id"] = msg.Id,
+				}))
 			end
 		end
 
 		if Owner then
-			utils.Send(
-				msg,
-				notices.credit({
-					From = msg.From,
-					Sender = Owner,
-					Recipient = Owner,
-				})
-			)
+			ao.send(notices.credit({
+				From = msg.From,
+				Sender = Owner,
+				Recipient = Owner,
+			}))
 		end
 
 		if AntRegistryId then

test/evolve.test.mjs

@@ -44,6 +44,7 @@ describe('aos Evolve', async () => {
       },
       evolveResult.Memory,
     );
+
     assert(evalResult.Output.data);
     assert(evalResult.Output.data.includes('info'));
   });

test/memory/json.test.mjs

@@ -0,0 +1,40 @@
+import { createAntAosLoader } from '../utils.mjs';
+import { describe, it } from 'node:test';
+import assert from 'node:assert';
+import {
+  AO_LOADER_HANDLER_ENV,
+  DEFAULT_HANDLE_OPTIONS,
+} from '../../tools/constants.mjs';
+
+describe('JSON limits', async () => {
+  const { handle: originalHandle, memory: startMemory } =
+    await createAntAosLoader();
+
+  async function handle(options = {}, mem = startMemory) {
+    return originalHandle(
+      mem,
+      {
+        ...DEFAULT_HANDLE_OPTIONS,
+        ...options,
+      },
+      AO_LOADER_HANDLER_ENV,
+    );
+  }
+
+  it('should not be able to parse a large json', async () => {
+    const data = JSON.stringify(
+      new Array(1).fill({
+        transactionId: ''.padEnd(43, '1'),
+        ttlSeconds: 3600,
+        name: '@',
+      }),
+    );
+    console.log('parsing data size: ' + data.length);
+    const result = await handle({
+      Data: data,
+      Tags: [{ name: 'Content-Type', value: 'application/json' }],
+    });
+
+    console.dir(result, { depth: null });
+  });
+});

test/records.test.mjs

@@ -159,4 +159,25 @@ describe('aos Records', async () => {
     assert(record.transactionId === ''.padEnd(43, '3'));
     assert(record.ttlSeconds === 900);
   });
+
+  it('should be able to set 3k records', async () => {
+    let recordMem = startMemory;
+    for (let i = 0; i < 10_000; i++) {
+      if (!(i % 100)) {
+        console.log(i + '/10k');
+      }
+      const res = await setRecord(
+        {
+          name: i.toString(),
+          transactionId: ''.padEnd(43, '1'),
+          ttl: 900,
+        },
+        recordMem,
+      );
+      recordMem = res.Memory;
+    }
+    const recordsRes = await getRecords(recordMem);
+    console.log('retrieved ' + Object.keys(recordsRes).length + ' records');
+    assert(recordsRes, 'unable to get records');
+  });
 });

version.mjs

@@ -1,3 +1,3 @@
 // TODO: make this an auto generated file
 
-export default '12';
+export default '13';