Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sbom): set User-Agent header on requests to Rekor #7396

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

bobcallaway
Copy link
Contributor

@bobcallaway bobcallaway commented Aug 26, 2024

Description

  • Added functionality to set the User-Agent header in Trivy when making requests to Sigstore's Rekor transparency log.
  • Updated tests to cover the new functionality and ensure that the User-Agent header is properly set.

This enhancement is important for distinguishing requests to Rekor. It aids in tracking and managing Trivy requests more effectively.

Before the User-Agent header was just a plain Go-http-client/2.0. After the change, it becomes trivy/version.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@knqyf263
Copy link
Collaborator

Thanks for your contribution. I triggered tests.

Signed-off-by: Bob Callaway <[email protected]>
@knqyf263 knqyf263 added this pull request to the merge queue Sep 3, 2024
Merged via the queue into aquasecurity:main with commit af1d257 Sep 3, 2024
12 checks passed
@aqua-bot aqua-bot mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants