fix: use --file-patterns flag for all post analyzers
#7365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knqyf263
reviewed
Sep 2, 2024
| @@ -65,7 +66,7 @@ func (a packagingAnalyzer) PostAnalyze(_ context.Context, input analyzer.PostAna | |||
| var apps []types.Application | |||
|
|
|||
| required := func(path string, _ fs.DirEntry) bool { | |||
| return filepath.Base(path) == "METADATA" || isEggFile(path) | |||
| return filepath.Base(path) == "METADATA" || isEggFile(path) || slices.Contains(input.FilePatterns, path) | |||
There was a problem hiding this comment.
A file may not end with .egg if --file-patterns is specified. But I don't have a simple idea of how to handle that. We may want to ignore the edge case.
There was a problem hiding this comment.
We may need to split this analyzer into two analyzers for .egg and .egg-info.
There was a problem hiding this comment.
We may need to split this analyzer into two analyzers for .egg and .egg-info.
I agree with this decision.
Split analyzers in afb7387
There was a problem hiding this comment.
Can we make it a separate PR?
pkg/fanal/analyzer/analyzer.go
Outdated
| Options AnalysisOptions | ||
| FS fs.FS | ||
| Options AnalysisOptions | ||
| FilePatterns []string |
There was a problem hiding this comment.
Is this filed for file patterns? It looks like matched file paths.
There was a problem hiding this comment.
Updated filed name in 5f493ac
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
--file-patternsflag for all post analyzers.Related issues
--file-patternsdoesn't work for somepost-analyzers#6962Checklist