fix(helm): explicitly define kind and apiVersion of volumeClaimTemplate element

[LucasVanHaaren]

Description

Hello, I made a quick fix to define explicitly all volumeClaimTemplate field.
This allows to use gitops tools (like argoCD) to sync raw k8s manifests (built via helm) with cluster resources. Without these fields defined, these will be added in the cluster resource resulting in an OutOfSync with the generated manifest.

Feel free to discuss this fix in the below linked discussion.

Related issues

Like mentionned in guidelines for contributing, I think this change is trivial. This is why I created this PR without any Issue linked.
Nevertheless, I oepened a discussion here: #7361

Checklist

• I've read the guidelines for contributing to this repository.
• I've followed the conventions in the PR title.
• I've added tests that prove my fix is effective or that my feature works.
• I've updated the documentation with the relevant information (if needed).
• I've added usage information (if the PR introduces new options)
• I've included a "before" and "after" example to the description (if the PR is a user interface change).

[CLAassistant]

All committers have signed the CLA.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[LucasVanHaaren]

Hey @knqyf263 @simar7, what do you think about this ?

[afdesk]

If I understand correctly from the docs, PersistentVolumeClaim is created by default. so this update doesn't affect on k8s deploying.

But it seems ArgoCD tries to compare the state in the cluster with what is specified, it notices that the kind and apiVersion are not specified in one place, and it considers this a discrepancy, which leads to an "out of sync" state.

So I think It makes sense.

[afdesk]

Also it's useful if the k8s behavior will be changed.

[afdesk]

@LucasVanHaaren thanks for your contribution! LGTM!

[LucasVanHaaren]

Hello, thanks for merging it!

I just noticed that no new chart versions have been released with this modification.
Do you plan to release a new revision of the helm chart with only this one or you wait for other fixes before releasing?

[afdesk]

I just noticed that no new chart versions have been released with this modification. Do you plan to release a new revision of the helm chart with only this one or you wait for other fixes before releasing?

oh, It's my mistake. I'll think over and update the helm version soon.
thanks

[rverchere]

@LucasVanHaaren FYI, it's a more generic issue with all Statefulsets using PVC Templates, see argoproj/argo-cd#11143.

As a workaround, you can add annotation argocd.argoproj.io/compare-options: ServerSideDiff=true.