Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(julia): Add license detection for Julia #7327

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Octogonapus
Copy link
Contributor

@Octogonapus Octogonapus commented Aug 11, 2024

Description

Add license detection for Julia packages.

This is incomplete, I will add tests where needed and remove extraneous code before marking this PR as ready. First I am asking for some maintainer feedback:

Julia packages often don't specify their license in their Project.toml file (even though they should). I've included some rudimentary content-based license detection to help with that because I'm not sure if this project would accept adding a dependency for this. There are some dependencies (e.g. licensecheck and go-license-detector) which do a better job. What do you think about adding a dependency for license detection?

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant