Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(scan): --file-patterns doesn't work for some post-analyzers #6962

Open
DmitriyLewen opened this issue Jun 19, 2024 · 0 comments · May be fixed by #7365
Open

bug(scan): --file-patterns doesn't work for some post-analyzers #6962

DmitriyLewen opened this issue Jun 19, 2024 · 0 comments · May be fixed by #7365
Assignees
@DmitriyLewen
Labels
kind/bug Categorizes issue or PR as related to a bug.
Milestone
v0.56.0

Comments

@DmitriyLewen
Copy link
Contributor

Description

In most post-analyzers we use required function in PostAnalyze.

trivy/pkg/fanal/analyzer/language/nodejs/npm/npm.go

Lines 49 to 51 in 3eecfc6

required := func(path string, _ fs.DirEntry) bool {
return filepath.Base(path) == types.NpmPkgLock
}

But we don't have info about file-patterns in PostAnalyze function.
That is why --file-patterns flag may not work.

We need to update our logic to take into account file-patterns for PostAnalyze

Related Issue
@DmitriyLewen DmitriyLewen added the kind/bug Categorizes issue or PR as related to a bug. label Jun 19, 2024
@DmitriyLewen DmitriyLewen mentioned this issue Jun 19, 2024
Closed
2 tasks
@knqyf263 knqyf263 added this to the v0.55.0 milestone Jul 31, 2024
@DmitriyLewen DmitriyLewen linked a pull request Aug 21, 2024 that will close this issue
Open
6 tasks
@knqyf263 knqyf263 modified the milestones: v0.55.0, v0.56.0 Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DmitriyLewen DmitriyLewen

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
Trivy Roadmap
Status: No status
Milestone
v0.56.0
Development

Successfully merging a pull request may close this issue.

fix: use --file-patterns flag for all post analyzers DmitriyLewen/trivy
2 participants
@knqyf263 @DmitriyLewen