test(bundle): Verify bundle usage #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simar7
force-pushed
the
improve-buundle-verify
branch
from
931ef1c
to
45a5b8a
Compare
simar7
force-pushed
the
improve-buundle-verify
branch
from
45a5b8a
to
db0462e
Compare
nikpivkin
reviewed
Jul 9, 2024
| @@ -14,6 +15,7 @@ import ( | |||
|
|
|||
| var bundlePath = "bundle.tar.gz" | |||
| var OrasPush = []string{"--config", "/dev/null:application/vnd.cncf.openpolicyagent.config.v1+json", fmt.Sprintf("%s:application/vnd.cncf.openpolicyagent.layer.v1.tar+gzip", bundlePath)} | |||
| var supportedTrivyVersions = []string{"latest", "canary"} // TODO: add more versions | |||
There was a problem hiding this comment.
More versions will be added later?
There was a problem hiding this comment.
I wasn't able to find a way without using Docker's API (requires a token) to be able to fetch tags. We could scrape them but I thought we can start with these first and then improve upon.
Do you know of any way to get the tags without auth or scrape?
There was a problem hiding this comment.
We can retrieve the tags from GitHub.
nikpivkin
approved these changes
Jul 9, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: aquasecurity/trivy#7031