Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Readme.md #4297

Closed
wants to merge 2 commits into from
Closed

Update Readme.md #4297

wants to merge 2 commits into from

Conversation

LJTian
Copy link

@LJTian LJTian commented Sep 11, 2024

Fix docs address

Fix docs address
@CLAassistant
Copy link

CLAassistant commented Sep 11, 2024

CLA assistant check
All committers have signed the CLA.

@geyslan
Copy link
Member

geyslan commented Sep 11, 2024

@LJTian thank you for this contribution. @itaysk do you think we should move that link from home to docs overview?

@LJTian
Copy link
Author

LJTian commented Sep 13, 2024

I have some opinions:

  1. The context information in Readme.md points to the document and should not jump to the homepage.
  2. However, there is no detailed introduction in the document, so I think it should be supplemented.

@ShohamBit
Copy link

i think it is batter that it points to the hime and nit directly to the docs section, it's just make more sense to me

@itaysk
Copy link
Collaborator

itaysk commented Sep 16, 2024

I don't have a strong opinion, but it does intentionally point to the home and not docs. I don't think this change is needed

@geyslan
Copy link
Member

geyslan commented Sep 17, 2024

Closing as not needed. @LJTian Nevertheless, please be our guest to contribute. If you have any questions, just ask us.

@geyslan geyslan closed this Sep 17, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants