Tied django-livesettings commit #238
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I haven't fully investigated this yet but a couple of people have reported a RECURSIVE_RELATIONSHIP_CONSTANT error in actionitems. This seems to be due in part to an incompatibility with the latest version of django-livesettings, which is generating an error about config_register not being imported in publicweb/config.py. At some point we're going to need to change this to: from livesettings.functions import ... The quickest fix is to tie our version of livesettings to a working commit. This is probably good practice anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't fully investigated this yet but a couple of people have
reported a RECURSIVE_RELATIONSHIP_CONSTANT error in actionitems.
This seems to be due in part to an incompatibility with the latest
version of django-livesettings, which is generating an error about
config_register not being imported in publicweb/config.py. At some
point we're going to need to change this to:
from livesettings.functions import ...
The quickest fix is to tie our version of livesettings to a working
commit. This is probably good practice anyway.