Consumption benchmarking #443
Open
+60
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
|
||
| AdePTTrackingManager::~AdePTTrackingManager() | ||
| { | ||
| auto tid = G4Threading::G4GetThreadId(); |
There was a problem hiding this comment.
Suggested change
| auto tid = G4Threading::G4GetThreadId(); |
Unused variable that caused a warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
ENABLE_POWER_METERcmake option in order to do power consumption measurements.If the option is enabled, we use the power meter library to launch a background thread taking measurements from CPU and GPU. The monitoring is started once AdePT initialization is finished, and ends when shutting down the application.
Note that if the option is enabled, simulations need to be run with root access, which is required in order to read the CPU's MSR registers.
Prior to Geant4 11.3 the specialized tracking managers were not deleted by Geant4. Since the power meter is stopped in the tracking manager destructor, this will lead to an error message in older geant4 versions when the program ends without joining the power meter thread. This should not cause a memory leak, since
terminate()will be called on the unjoined thread.