Add comments, add conditional based on matrix.config.image 2021 and 2…

…022, remove sudo. Signed-off-by: Andre Pradhana <[email protected]>
apradhana · Sep 7, 2024 · 2e5f5d4 · 2e5f5d4
1 parent f77872a
commit 2e5f5d4
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 2 deletions.
diff --git a/.github/workflows/ax.yml b/.github/workflows/ax.yml
@@ -75,6 +75,7 @@ jobs:
       fail-fast: false
     steps:
       - name: Enable Node 16
+        if: contains(matrix.config.image, '2021') || contains(matrix.config.image, '2022')
         run: |
           echo "ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true" >> $GITHUB_ENV
       - uses: actions/checkout@v3

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -87,6 +87,8 @@ jobs:
       fail-fast: false
     steps:
     - name: Enable Node 16
+      # Solution taken from https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default
+      if: contains(matrix.config.image, '2022')
       run: |
         echo "ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true" >> $GITHUB_ENV
     - uses: actions/checkout@v3

diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
@@ -55,6 +55,8 @@ jobs:
     #   run: pip install epydoc
     - name: install_latex
       run: |
+        # Fix error: Cannot prepare internal mirrorlist: No URLs in mirrorlist. CentOS 8 reached EOL means need to replace the official mirror to vault.centos.org
+        # Comment out mirrorlist and replace #baseurl=...mirror.centos.org with baseurl=...vault.centos.org in files starting with CentOS- in /etc/yum.repos.d folder
         sed -i 's/mirrorlist/#mirrorlist/g' /etc/yum.repos.d/CentOS-*
         sed -i 's|#baseurl=http://mirror.centos.org|baseurl=http://vault.centos.org|g' /etc/yum.repos.d/CentOS-*
         yum -y install texlive-latex-bin texlive-dvips texlive-collection-fontsrecommended texlive-collection-latexrecommended

diff --git a/.github/workflows/nanovdb.yml b/.github/workflows/nanovdb.yml
@@ -66,11 +66,14 @@ jobs:
       fail-fast: false
     steps:
       - name: Enable Node 16
+        if: contains(matrix.config.image, '2022')
         run: |
           echo "ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true" >> $GITHUB_ENV
       - uses: actions/checkout@v3
       - name: install_cuda_11
         run: |
+          # Fix error: Cannot prepare internal mirrorlist: No URLs in mirrorlist. CentOS 8 reached EOL means need to replace the official mirror to vault.centos.org
+          # Comment out mirrorlist and replace #baseurl=...mirror.centos.org with baseurl=...vault.centos.org in files starting with CentOS- in /etc/yum.repos.d folder
           sed -i 's/mirrorlist/#mirrorlist/g' /etc/yum.repos.d/CentOS-*
           sed -i 's|#baseurl=http://mirror.centos.org|baseurl=http://vault.centos.org|g' /etc/yum.repos.d/CentOS-*
           yum -y install yum-utils
@@ -167,12 +170,12 @@ jobs:
         run: ./ci/install_macos.sh
       - name: build
         run: >
-          sudo ./ci/build.sh -v
+          ./ci/build.sh -v
           --build-type=${{ matrix.config.build }}
           --components=core,nano,nanotest,nanoexam,nanobench,nanotool
           --cargs=\'-DUSE_EXPLICIT_INSTANTIATION=OFF -DNANOVDB_USE_CUDA=OFF -DNANOVDB_USE_OPENVDB=ON\'
       - name: test
-        run: cd build && sudo ctest -V -E ".*cuda.*"
+        run: cd build && ctest -V -E ".*cuda.*"
 
   nanovdb-lite:
     if: |

diff --git a/.github/workflows/weekly.yml b/.github/workflows/weekly.yml
@@ -260,6 +260,7 @@ jobs:
       fail-fast: false
     steps:
       - name: Enable Node 16
+        if: contains(matrix.config.image, '2021') || contains(matrix.config.image, '2022')
         run: |
           echo "ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true" >> $GITHUB_ENV
       - uses: actions/checkout@v3