fix(cli): detect TypeScript SDK in devDependencies - #1889
Merged
Conversation
Contributor
Greptile SummaryThis PR extends TypeScript type generation to detect supported Appwrite SDK packages in
Confidence Score: 5/5The PR appears safe to merge; no actionable correctness, security, or repository-rule violations remain. The implementation preserves dependency precedence and fallback behavior while directly testing the meaningful manifest and monorepo cases introduced by the change. Important Files Changed
Reviews (3): Last reviewed commit: "Merge remote-tracking branch 'origin/mai..." | Re-trigger Greptile |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
devDependencieswhen no supported SDK is found independencieswhen generating TypeScript types.Fixes appwrite/appwrite#10131
Testing
go mod tidy,go build ./...,go vet ./...,go test ./...pass.node-appwritein devDependencies and passes after it.packages/appwrite-types/srccompile with actual appwrite@27.0.0/node-appwrite@29.0.0 and TypeScript@7.0.2, for both dependency sections (strict: true,skipLibCheck: false). Before the fix, Node dev-only produces TS2307; after it, compilation passes.CI formatting follow-up
The live spec exposed a baseline empty-header formatting issue in OAuth2 services. Meanwhile, merged PR #1888 fixed response-media fallback on main and eliminated the empty-header case. Merged main and reverted the redundant formatter follow-up, keeping this PR's final diff limited to the original three CLI files.
After merging main, clean generation and
format:checkpass for all three previously failing targets: Web client, Web console, and React Native client. Generated files were not formatted in place.Validation limitations
The original CLI head
7696365passed remoteTests / CLIGo126and the CLI generation/build job (CI run). On the updated heada3aae9a, both CI and Validation pass, including all three previously failing SDK targets. All reported PR checks pass; Greptile confidence is 5/5.Local Docker CLI e2e evidence remains inconclusive: the repository's global
mockapiCompose identity collided with another worktree's concurrent test run, and cleanup removed the other worktree's replacement mock container. No further Docker operations were performed after escalation. The remote CLI test pass supplies independent verification for the original CLI fix; the passing offline regression and compilation checks above are also independent of the local Docker incident.A genuine Terminal screenshot was attempted but macOS
screencapturecould not create the window image; no screenshot is attached.