Add telemetry and cancellable inference - #10
Merged
Conversation
Greptile SummaryThe latest changes complete the telemetry and cancellation fixes requested by the previous review.
Confidence Score: 5/5The PR appears safe to merge; both previous findings are resolved and the latest changes introduce no accepted new issue. The handler now prevents successful responses after request cancellation, and server-boundary instrumentation covers registered, metrics, and unmatched routes without introducing an established functional failure. Important Files Changed
Reviews (2): Last reviewed commit: "fix: cover post-inference cancellation a..." | Re-trigger Greptile |
loks0n
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/healthzcompatibilityValidation
go test -race ./...go vet ./...make buildnpm run build --prefix docsgit diff --checkDocker validation could not run locally because the Docker daemon is not running; the existing CI matrix builds both amd64 and arm64 images. The integration suite will exercise real ONNX inference and the new cancellation assertion in CI.