test: replaced some dummy APIs #36655
Conversation
NandanAnantharamu
requested review from
ApekshaBhosale and
sagar-qa007
as code owners
WalkthroughThe changes in the pull request involve modifications to the Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
github-actions
bot
added
skip-changelog
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
- app/client/cypress/support/Objects/DataManager.ts (2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
app/client/cypress/support/Objects/DataManager.ts (1)
Pattern
app/client/cypress/**/**.*: Review the following e2e test code written using the Cypress test library. Ensure that:
- Follow best practices for Cypress code and e2e automation.
- Avoid using cy.wait in code.
- Avoid using cy.pause in code.
- Avoid using agHelper.sleep().
- Use locator variables for locators and do not use plain strings.
- Use data-* attributes for selectors.
- Avoid Xpaths, Attributes and CSS path.
- Avoid selectors like .btn.submit or button[type=submit].
- Perform logins via API with LoginFromAPI.
- Perform logout via API with LogOutviaAPI.
- Perform signup via API with SignupFromAPI.
- Avoid using it.only.
- Avoid using after and aftereach in test cases.
- Use multiple assertions for expect statements.
- Avoid using strings for assertions.
- Do not use duplicate filenames even with different paths.
- Avoid using agHelper.Sleep, this.Sleep in any file in code.
🔇 Additional comments (1)
app/client/cypress/support/Objects/DataManager.ts (1)
108-108:⚠️ Potential issueClass, let's discuss the change in our
authenticatedApiUrl.I see you've updated our API URL, but I have a few points for us to consider:
- We've switched from "https" to "http". Can anyone tell me why this might be a concern?
- The new URL uses "host.docker.internal". Who can explain what this means for our development environment?
- We've added a specific port number. Why might this be important?
Let's think about these questions and discuss how they might affect our application's security and deployment process.
To verify the impact of this change, let's run a quick check:
Can someone volunteer to run this script and share the results with the class?
Also applies to: 205-205
|
|
||
| GraphqlApiUrl_TED: "http://host.docker.internal:4200/graphql", | ||
|
|
||
| twilio_username: "random-username", | ||
| twilio_password: "random-password", | ||
|
|
||
| okta_username: "[email protected]", |
There was a problem hiding this comment.
Let's examine the new okta_username property, class.
I notice we've added a new property for Okta authentication. This is an interesting addition to our configuration. However, I have a few questions for you to ponder:
- Why might using the same email for both Production and Staging environments be problematic?
- Can anyone explain the potential risks of hardcoding credentials in our code?
- How could we improve this implementation to align with best security practices?
Remember, in the real world, we always want to protect our application and user data. Let's brainstorm some better approaches to handling authentication credentials.
Would you like me to propose a more secure way to manage these credentials? We could explore environment variables or a secure credential management system.
Also applies to: 212-212
removed unwanted data
NandanAnantharamu
added
ok-to-test
|
closing this as its redundant |
/ok-to-test tags="@tag.All"
EE PR: https://github.com/appsmithorg/appsmith-ee/pull/5272
Caution
🔴 🔴 🔴 Some tests have failed.
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11162865103
Commit: 205958c
Cypress dashboard.
Tags: @tag.All
Spec:
The following are new failures, please fix them before merging the PR:
- cypress/e2e/Regression/ClientSide/ExplorerTests/Widgets_Sidebar.ts
List of identified flaky tests.Thu, 03 Oct 2024 16:50:28 UTC
Summary by CodeRabbit
New Features
Bug Fixes