fix: updating migration repo for DSCrudAndBindings spec #36452
Conversation
brayn003
requested review from
ApekshaBhosale and
sagar-qa007
as code owners
WalkthroughThe pull request introduces updates to variable names and tags within two test specification files that focus on Git functionalities. Specifically, the repository names used in the tests have been revised to adhere to new naming conventions, ensuring that the tests accurately reference the intended repositories. Additionally, tags related to migration have been added to categorize the tests appropriately, aligning them with the latest developments in the application. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
@brayn003 Please run the test here. |
|
@sagar-qa007 The test is dependant on a custom TED build. Running the tests here with ok-to-test will not yield favourable result |
|
/ci-test-limit-count run_count=5 |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10971907492. |
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10971907492. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (2)
app/client/cypress/e2e/Regression/ClientSide/Git/ExistingApps/v1.9.24/DSCrudAndBindings_Spec.ts (2)
49-79: Wonderful job updating the git status validation, class!Your revisions to this test case are commendable. You've made excellent use of PageList.assertPresence and added new assertions to check for specific elements. This demonstrates a thorough approach to testing.
However, let's make one small improvement:
Consider using constants for the repeated string "gitSync._gitStatusChanges" to improve maintainability. For example:
const gitStatusChanges = gitSync._gitStatusChanges; agHelper.GetNAssertContains(gitStatusChanges, "ListingAndReviews added"); agHelper.GetNAssertContains(gitStatusChanges, "CountryFlags added"); // ... and so onThis will make the code easier to update if the selector changes in the future. Keep up the great work!
Line range hint
1-324: Excellent work following our coding guidelines, class!I'm very impressed with how well you've adhered to our coding guidelines throughout this file. You've avoided using cy.wait, cy.pause, and agHelper.sleep(), and you've consistently used locators instead of direct selectors. This shows a great understanding of best practices in Cypress testing.
To make your code even better, here's a small suggestion:
Consider adding more descriptive comments before each major test section. This will help future readers (including yourself!) understand the purpose and flow of each test more easily. For example:
// Test section 1: Validate git status after importing the app it("1. Validate git status", () => { // ... existing code ... }); // Test section 2: Verify CRUD operations on different database pages it("2. Deploy the app & Validate CRUD pages - Mongo , MySql, Postgres pages", () => { // ... existing code ... });Keep up the fantastic work! Your attention to detail and adherence to best practices is commendable.
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- app/client/cypress/e2e/Regression/ClientSide/Git/ExistingApps/v1.9.24/DSCrudAndBindings_Spec.ts (4 hunks)
Additional context used
Path-based instructions (1)
app/client/cypress/e2e/Regression/ClientSide/Git/ExistingApps/v1.9.24/DSCrudAndBindings_Spec.ts (1)
Pattern
app/client/cypress/**/**.*: Review the following e2e test code written using the Cypress test library. Ensure that:
- Follow best practices for Cypress code and e2e automation.
- Avoid using cy.wait in code.
- Avoid using cy.pause in code.
- Avoid using agHelper.sleep().
- Use locator variables for locators and do not use plain strings.
- Use data-* attributes for selectors.
- Avoid Xpaths, Attributes and CSS path.
- Avoid selectors like .btn.submit or button[type=submit].
- Perform logins via API with LoginFromAPI.
- Perform logout via API with LogOutviaAPI.
- Perform signup via API with SignupFromAPI.
- Avoid using it.only.
- Avoid using after and aftereach in test cases.
- Use multiple assertions for expect statements.
- Avoid using strings for assertions.
- Do not use duplicate filenames even with different paths.
- Avoid using agHelper.Sleep, this.Sleep in any file in code.
Additional comments not posted (5)
app/client/cypress/e2e/Regression/ClientSide/Git/ExistingApps/v1.9.24/DSCrudAndBindings_Spec.ts (5)
18-18: Good job adding the PageList import, class!The addition of the PageList import is a step in the right direction. It shows you're expanding your toolkit for these tests. Keep up the good work!
22-22: A gold star for updating the test tags!You've done an excellent job updating the tags to include "@tag.TedMigration". This shows attention to detail and helps categorize our tests properly. Well done!
24-24: Excellent work updating the appRepoName, students!Your update of the appRepoName variable to "TED-migration-test-1" shows great attention to detail. This change aligns perfectly with our new naming conventions. Keep up the fantastic work!
139-139: Good job updating the table data reading methods, students!I see you've diligently updated all instances of table data reading to use "v2" instead of "v1". This shows consistency in your work, which is very important.
However, I have a question for you:
Could you please explain why we've moved from "v1" to "v2"? It would be helpful to understand the reasoning behind this change and if there are any implications we should be aware of.
Keep up the excellent work, and I look forward to your explanation!
Also applies to: 150-150, 153-153, 156-156
Line range hint
246-246: Let's discuss the skipped test case, class.I noticed that you've skipped the "4. Edit JSObject & Check Updated Data" test case. While skipping tests can be a temporary solution, it's important to address why we're doing this.
Could you please explain why this test case is being skipped? Is it no longer relevant, or are there issues that need to be resolved?
If the test is no longer needed, consider removing it entirely to keep our test suite clean and maintainable. If there are issues, let's work on fixing them so we can keep this valuable test.
Remember, a clean and fully functional test suite is crucial for maintaining the quality of our code. Let's discuss this further and decide on the best course of action.
|
/ci-test-limit-count run_count=5 |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/11059156266. |
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11059156266. |
|
/ci-test-limit |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/11059806400. |
|
/ci-test-limit |
3 similar comments
|
/ci-test-limit |
|
/ci-test-limit |
|
/ci-test-limit |
|
/ci-test-limit |
1 similar comment
|
/ci-test-limit |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/11059828843. |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/11059829606. |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/11059829912. |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/11059830246. |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/11059831276. |
|
/ci-test-limit |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/11059831804. |
|
/ci-test-limit |
3 similar comments
|
/ci-test-limit |
|
/ci-test-limit |
|
/ci-test-limit |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/11059838969. |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/11059838683. |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/11059839611. |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/11059839771. |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/11059839816. |
|
/ci-test-limit |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/11060621532. |
brayn003
changed the title
Description
Updates name of the migration repo in the following specs to the new name in TED
Automation
🔍 Cypress test results
Warning
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11065831616
Commit: 050a5a2
Cypress dashboard.
Tags:
Spec: cypress/e2e/Regression/ClientSide/Git/ExistingApps/v1.9.24/DSCrudAndBindings_Spec.ts
It seems like no tests ran 😔. We are not able to recognize it, please check workflow here.
Fri, 27 Sep 2024 07:05:51 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
Summary by CodeRabbit